This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
updated readme #11
Merged
updated readme #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adducci @thinkterry - could you code review this SDK update PR when you have a moment? |
lsi1verthorn
approved these changes
Sep 27, 2018
radduccijc
approved these changes
Sep 27, 2018
bross-jc
approved these changes
Sep 27, 2018
marc-jc
reviewed
Sep 27, 2018
| @@ -31,3 +31,9 @@ $ docker-compose run --rm swagger-codegen generate -i /swagger-api/yaml/index2.y | |||
| This will generate the API v2 client files under `output/jcapiv2` | |||
|
|
|||
| Once you are satisfied with the generated API client, you can replace the existing files under the `jcapiv1` and `jcapiv2` folders with your generated files. | |||
| ``` | |||
| rm -rf jcapiv1 | |||
| mv output/jcapiv1 . | |||
There was a problem hiding this comment.
Above it looks like the commands use /swagger-api/out/jcapiv[1|2]. SHould output be just out? Also, using absolute paths here might be more clear, if not too verbose.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated readme